Skip to content

Remove Data[], message to state, modified test #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
javi9231 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove Data[], message to state, modified test #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions src/subscribe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ function parse(message) {
function defaultDispatch(topic, message, packet) {
const { state } = this;
const m = parse(message);
const newData = [
m,
...state.data
];
this.setState({ data: newData });

this.setState({
message: m
});
};


Expand All @@ -42,7 +41,7 @@ export default function subscribe(opts = { dispatch: defaultDispatch }) {
this.client = props.client || context.mqtt;
this.state = {
subscribed: false,
data: [],
message: ''
};
}

Expand All @@ -59,7 +58,7 @@ export default function subscribe(opts = { dispatch: defaultDispatch }) {
render() {
return createElement(TargetComponent, {
...omit(this.props, 'client'),
data: this.state.data,
message: this.state.message,
mqtt: this.client
});
}
Expand All @@ -79,4 +78,4 @@ export default function subscribe(opts = { dispatch: defaultDispatch }) {
}
return MQTTSubscriber;
}
}
}
10 changes: 5 additions & 5 deletions test/subscribe.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ describe('Subscribe', (test) => {
<SubscribedComponent client={stub} />
);
stub.publish(demoTopic, demoMessage);
const data = mounted.first().prop('data');
t.true(data[0] === demoMessage);
const m = mounted.first().prop('message');
t.true(m === demoMessage);
});

test('receives JSON data and parses it', (t) => {
Expand All @@ -57,9 +57,9 @@ describe('Subscribe', (test) => {
<SubscribedComponent client={stub} />
);
stub.publish(demoTopic, JSON.stringify(demoMessage));
const data = mounted.first().prop('data');
t.truthy(data[0]);
t.true(data[0].value === demoMessage.value);
const m = mounted.first().prop('message');
t.truthy(m);
t.true(m.value === demoMessage.value);
})


Expand Down