Conversation
added 7 commits
February 3, 2026 10:29
…y to signal a lack of interest in an ACK response.
…th a default of 1000, which was good for about 4000 fire-and-forget requests before the buffer ran out.
weren't necessary.
added 5 commits
February 3, 2026 14:23
… the absence of a response could also be requested by the client.
added 2 commits
February 3, 2026 15:17
Contributor
tylertucker202
left a comment
There was a problem hiding this comment.
I'm seeing a lot of repeated code. Would it be possible to implement a function here?
def get_reply(message):
try:
reply = message.payload.reply
except SomeExpectedException:
reply = True
return reply
Then you can reuse this method wherever.
contents but I missed a few of the names.
Contributor
Author
|
I'm leaning towards setting up the logic as a property in the Payload class, which would eliminate the need to carry the what's a reasonable-default logic around. |
Contributor
Author
|
That looks cleaner to me. I still need to test it more thoroughly, then I'll move it out of draft status. |
Contributor
Author
|
Tests check out, there doesn't appear to be a performance impact from handling the 'reply' attribute as a property. |
tylertucker202
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request disables all responses from the server that would normally be triggered in response to a SET request. If a normal blocking SET request can be issued 5000 times per second, a client not waiting for a full response can instead issue 5500 requests per second, a client not waiting for any response can issue 40000 requests per second.