Conversation
added 28 commits
February 10, 2026 09:55
description of items.
item that uses H:M:S formatting.
Contributor
Author
|
Test coverage isn't everything, but it's a number, and it's fun to make the numbers go up. To this point, the changes committed represent an 8% increase in test coverage overall (to 51%), with a 4% improvement in item.py (to 58%), and 26% improvement in config.py (to 48%). |
added 6 commits
February 12, 2026 10:09
being passed an Item instance as an argument.
trying to instantiate an Item.
Contributor
Author
|
This pull request is starting to get a bit big, so I'll stop here and submit a new one for further tests. I've started to branch out from item specific testing and I don't want the focus to get too broad; though the deltas are largely confined to the unit tests themselves there are a handful of fixes creeping in for other files. |
mkb0517
approved these changes
Mar 3, 2026
mkb0517
left a comment
mkb0517
left a comment
There was a problem hiding this comment.
This looks like a reasonable start for unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding unit test coverage, largely focusing on client-facing usage of items. A few fixes for the configuration handling of enumerated and enumerated-like types are included here, after problems were highlighted in the creation of their respective unit tests.