Small Additions -- Cumulative

[oefirouz]

Hi,

I added a cumulative total to the Maturing-Cards graph, and changed the color schema a bit. Feel free to do what you want with my changes, I just thought I'd send them to you so you can update the add-on rather than creating my own.

Thanks by the way for a great Add-on, you did 99.9% of the work.

Omede

[Kenishi]

I appreciate the submission although I'm not quite sure what the cumulative line is actually showing.

It doesn't stand to reason that the graph, if you add the numbers up, will equal out to the same number of cards in your deck. You can could mature 40 cards, but then turn around and fail them shortly after. The 1 year/Deck life span would still show the 40 cards. As just an example, when I load up the "deck life" for a deck of 7000 cards, it shows I have cumulative of ~7000 cards maturing over the span of the deck, yet I only have 75% cards that mature right now.

If I'm missing the point of the cumulative addition please let me know. I'd be more than glad to add the addition and update.

Thanks again for the submission.

Kenishi

[oefirouz]

Oh, your point is completely correct.

My goal was to have one graph to show my long term progress, and I
figured mature card count would work for that. But I didn't consider
the failing of mature cards.

I have updated it to plot promotions, demotions, and cumulative mature
cards, but I can't verify it as I don't have any failed mature cards.

I'll send a new pull request.

Thanks for catching the mistake.
Omede

On Jul 21, 2012, at 10:34 AM,
Kenishireply@reply.github.com
wrote:

I appreciate the submission although I'm not quite sure what the cumulative line is actually showing.

It doesn't stand to reason that the graph, if you add the numbers up, will equal out to the same number of cards in your deck. You can could mature 40 cards, but then turn around and fail them shortly after. The 1 year/Deck life span would still show the 40 cards. As just an example, when I load up the "deck life" for a deck of 7000 cards, it shows I have cumulative of ~7000 cards maturing over the span of the deck, yet I only have 75% cards that mature right now.

If I'm missing the point of the cumulative addition please let me know. I'd be more than glad to add the addition and update.

Thanks again for the submission.

Kenishi

---

Reply to this email directly or view it on GitHub:
#1 (comment)