forked from KosmicTask/F-Script
-
Notifications
You must be signed in to change notification settings - Fork 28
Merged @antmd 's and @Kentzo 's branches + own changes #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
perfaram
wants to merge
45
commits into
Kentzo:master
Choose a base branch
from
perfaram:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in floating window
… into macro calls
…d code in comments.
…iting does not work.
…jectInfo, to make it more readable and easier to extend
…eadable, and easier to extend
…h the same value.
…dow above others.
…ed FScript Test 2 and IBPlugin (not supported anymore)
NSUndefinedDateComponent -> NSDateComponentUndefined NSRunAlertPanel -> NSAlert +code style alerts (double parenthesis)
Owner
|
@perfaram Sorry it took so long, I'm reviewing it now. |
Owner
|
Owner
|
Would it be possible to split this PR into smaller ones? |
Author
|
Don't know... I'd rather fix things you ask me to, it's easier + merging only parts then re-merging other changes atop would make a rather messy tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.