Update to support latest version of BeatSaber (1.40.4)

[neboman11]

This PR contains the necessary changes in order to support BeatSaber 1.40.4 and all dependent mod changes.

[MiguVT]

Its working stable? I'm thinking to compile your fork myself.

[neboman11]

Last I used it, yes. No crashes anywhere. I haven't tested it with 1.40.5 yet though

[MiguVT]

I'm using ver 1.40.5 and no issues :) tysm for your fork, hope it get merged soon

[english0or0spanish]

it works on 1.40.7 but saves the video's and expects the .json in a different place than normal

[neboman11]

Have you checked out my reimplementation yet? It should respect the folders properly. If it doesn't, could you raise an issue on that repo with details?

[ericswpark]

@neboman11 this is something I noticed with this PR as well. Some of the maps in the built-in playlist aren't recognized as Cinema maps and don't even have the option to download the video, even though there is the metadata JSON file and the video file is already present from past versions.

I haven't migrated to your re-implementation yet; is there a comparison or a list of to-dos or is the re-implementation already complete in terms of feature parity?

[neboman11]

@ericswpark I haven't checked the exact feature parity between my version and the original, but most everything should be there. The only thing I'm aware of that's missing is multiplayer support and the environment manipulation to remove things that block the screen. If you find anything else, please let me know. I also am not sure about the playlist, I couldn't find in the original mod where the playlist was being added, so if someone can point that to me so I can either fix this fork or integrate it into my version, that would be great.

[ericswpark]

@neboman11 the playlist is available in the repo's Resources/ folder: https://github.com/Kevga/BeatSaberCinema/blob/master/Resources/cinema.bplist I'm not sure how it's included in the original mod; not very familiar with Beat Saber mod development yet.

What's weird is that not all maps are affected. Some maps show the video reference just fine (though it still prompts you to redownload them probably because the video location has been altered from the original mod). But some maps won't even display the Download button at all.

This is with the PR. I can test with your re-implementation; although it looks like release 0.0.3 doesn't have the built mod artifact as noted by this issue, so will check if the artifact gets uploaded or if I get a chance to build it myself.

[neboman11]

@ericswpark I have updated the release with the mod binary (my bad 😳).
Thank you for finding that playlist, don't know how I missed it. The reason some of them work is because there are apparently 2 different places that data can come from, and this is the second. I need to see if there's anything I need to do to support that playlist other than just including it in the mod.

[neboman11]

Looks like the playlist is just being added into the release zip, and not into the mod. I'll set it up so that gets added going forwards

[bestknighter]

@neboman11 I'm planning to give your rewrite a try! Will songs made for cinema be automatically compatible? By this I mean, songs where the mapper added a video with Cinema will work with this out of the get go? Will them still say that there is a recommended mod missing?

[neboman11]

@bestknighter Some of the songs will automatically get detected, but some won't unless you manually add this playlist file into your Playlists folder as well. You can also manually download the video using the mod menu on the left of the song list, check the readme on my repo for more details. I fixed the dependencies in the latest version, so as long as you install the required dependencies through BSManager or the like, you should be good. If it doesn't show up, you'll have to check the logs since IPA doesn't display anything in game if it can't load it.

[bestknighter]

Ok, thank you! Later I'll test and if need be I'll send you the logs.

[IEagleoneI]

add support via BSmanager for 1.40.8 pls, it's legacy now

[MiguVT]

We should add support for ver 1.40.8 and maybe (idk how hard will be) search how to support 1.40.9, cause new Unity Update and idk if beat saber had made some refactor.

Edit: @IEagleoneI also check https://github.com/neboman11/BeatSaberTheater
its a rewrite by @neboman11 and looks like supporting 1.40.8 (or at least 1.40.7)

[neboman11]

The latest version of Theater supports 1.40.8, but I need to wait for the mods it depends on before I can update to 1.40.9 since it's a bigger change. I will push an update as soon as I can.

[IEagleoneI]

Edit: @IEagleoneI also check https://github.com/neboman11/BeatSaberTheater its a rewrite by @neboman11 and looks like supporting 1.40.8 (or at least 1.40.7)

there is no such mod as Theater in BSManager mods list for 1.40.8

i am using only BSM mods for BS, don't really want checking every time for new versions and update it manually

[MiguVT]

Edit: @IEagleoneI also check https://github.com/neboman11/BeatSaberTheater its a rewrite by @neboman11 and looks like supporting 1.40.8 (or at least 1.40.7)

there is no such mod as Theater in BSManager mods list for 1.40.8

i am using only BSM mods for BS, don't really want checking every time for new versions and update it manually

I understand it but its why it should be added here: BeatSaberTheater/BeatSaberTheater#2

We can consider BeatSaberCinema a dead project (or at least for now)