Use earcut to triangulate polylist/polygons#215
Open
lasalvavida wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
Author
|
Comparison with BoxAnimated whose rectangular faces are made of four point polygons. Before (19.7kb)
After (15.3kb)
|
|
Does that reduce the number of triangles and points in the model? |
Contributor
Author
Only if those triangles/points are redundant/degenerate. As it is, this would only be applied for polygon conversion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #201
This goes along with transparency changes so that we don't introduce visual artifacts with transparent polygons. Overall, polygon/polylist meshes conversion should also produce smaller models.