Fix typo #321
Merged
Fix typo #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kpet
approved these changes
Mar 26, 2025
Merged
Contributor
Author
Contributor
|
Closing and reopening to re-trigger CI... |
Contributor
|
Hrm, I think we'd need to merge the latest main branch to see CI pass. I'm going to go ahead and merge this as-is. The fix looks correct, and even if it isn't, it'd be no worse off than it was previously. |
Menkib64
added a commit
to Menkib64/lc0
that referenced
this pull request
Jul 20, 2025
There has been incomåatible extension changes in opencl.h. My system opencl.h doesn't compile with old opencl.hpp because type names has changed. The new opencl.hpp adds version checks for incompatible extensions. There was a typo in the last release which was fixed by KhronosGroup/OpenCL-CLHPP#321. Therefore I choose to use the latest version from commit KhronosGroup/OpenCL-CLHPP@g2a60842
Menkib64
added a commit
to Menkib64/lc0
that referenced
this pull request
Jul 20, 2025
There has been incomåatible extension changes in opencl.h. My system opencl.h doesn't compile with old opencl.hpp because type names has changed. The new opencl.hpp adds version checks for incompatible extensions. There was a typo in the last release which was fixed by KhronosGroup/OpenCL-CLHPP#321. Therefore I choose to use the latest version from commit KhronosGroup/OpenCL-CLHPP@2a60842
Menkib64
added a commit
to Menkib64/lc0
that referenced
this pull request
Jul 20, 2025
There has been incompatible extension changes in opencl.h. My system opencl.h doesn't compile with old opencl.hpp because type names has changed. The new opencl.hpp adds version checks for incompatible extensions. There was a typo in the last release which was fixed by KhronosGroup/OpenCL-CLHPP#321. Therefore choice is the latest version from KhronosGroup/OpenCL-CLHPP@2a60842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CL_KHR_COMMAND_BUFFER_VERSIONis incorrect, should beCL_KHR_COMMAND_BUFFER_EXTENSION_VERSIONinstead, which is defined inCL/cl_ext.h. This fixes a compilation error seen with-Wundefand-Werror.