initialize return value for deterministic queries #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change I have been using locally for some time now that I've found useful, so I thought I'd see if it's something worth adding to the upstream C++ bindings. In short, for queries that return the result of the query directly (vs. through a pointer), the value that is returned is uninitialized. This means that if the query returns an error, the value that gets returned is most likely random and non-deterministic, which likely isn't what users expect.
With this change, the return values are always initialized, so even if an error occurs the query always returns a deterministic value. The return value is not always meaningful, or identifiable as a default value, but it frequently is, and even when it isn't it's beneficial to return a consistent value than a random value.