error on invalid getSupportedImageFormats arg #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashbaug
approved these changes
Oct 6, 2025
Contributor
bashbaug
left a comment
bashbaug
left a comment
There was a problem hiding this comment.
Thanks! I think this is the right behavior, and it is closest to the behavior of clGetSupportedImageFormats.
I'm going to merge this even though strictly speaking it is breaking compatibility (since previously valid usage is now an error). I don't think this will cause an issue in practice, and if it does, the prior behavior was probably covering up a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a nullptr should not succeed.
Follow up to #335