Invalid hash arguments to download_url#26
Draft
marvinborner wants to merge 2 commits intoKinWaiCheuk:masterfrom
Draft
Invalid hash arguments to download_url#26marvinborner wants to merge 2 commits intoKinWaiCheuk:masterfrom
marvinborner wants to merge 2 commits intoKinWaiCheuk:masterfrom
Conversation
Owner
|
Thank you for reporting this issue. AudioLoader/AudioLoader/utils.py Lines 108 to 115 in 37c1d86 And we can import it like this AudioLoader/AudioLoader/music/mss/musdbhq.py Lines 24 to 27 in 37c1d86 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the import uses a different function for torch 2.0, the arguments changed a bit. The function doesn't accept the checksums as before. I just removed it in this PR for now; this shouldn't be merged directly.
A better solution would probably be to use the new checksum arguments (SHA256) and remove support for torch <2 completely. But that's your decision I guess.
Edit: Some other arguments also changed.. Idk