Open
Conversation
KinWaiCheuk
requested changes
Nov 30, 2021
Owner
KinWaiCheuk
left a comment
KinWaiCheuk
left a comment
There was a problem hiding this comment.
Dataset does not download and does not extract correctly. Even with manual extractions and move files around to the correct path, it still throws an error.
| extract_archive(os.path.join(download_path, archive_name)) | ||
| print(f"Using all file from {self._path} ") | ||
| else: | ||
| raise FileNotFoundError(f"Dataset not found at {self._path}, please specify the correct location or set `download=True`") |
Owner
There was a problem hiding this comment.
Still get errors when the files are in the correct path
| #file exists and extracted | ||
| if os.path.isfile(os.path.join(download_path,archive_name)) and os.path.exists(self._path): | ||
| print(f"Dataset archive exists, all files are extracted. Using all file from {self._path} ") | ||
| #file exists but not extracted |
Owner
There was a problem hiding this comment.
The extraction is not automatic. The zip file contain nested zip files, this code does not deal with nested zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.