Releases: KindleModding/Hotfix
Releases · KindleModding/Hotfix
v2.3.7
v2.3.6 - Why does it still not launch???
Fixes some long-standing sh_integration bugs with path & blank icon handling
v2.3.5 - The one that won't launch
Fix sh_integration application error on armel devices by using an alternative strategy for graceful exits
v2.3.4 - The application error
Fix a regression in sh_integration that breaks lipc responses causing scriptlets to not launch
v2.3.3 - The one that devolves
Fixes some sh_integration launcher bugs
v2.3.2 - The sacred one
Fix sh_integration hook-related crashes
v2.3.1 - The one that can't run hooks
Hotfix v2.3.1 fixes a bug in sh_integration which manifested as scriptlets not appearing and constant crahs dumps.
I appologise for the inconvenience
Technical Info
- When a scriptlet is passed to the sh_integration extractor to index, the header must be read
- Reading the header happens in code similar to such:
buffer[0] = '\0';
int lineLength = 0;
char c;
while ((c = fgetc(file)) != EOF)
{
if (c == '\n' || c == '\r')
{
break;
}
if (lineLength + 2 >= bufferSize)
{
buffer = realloc(buffer, bufferSize+=(lineLength + 2));
if (buffer == NULL)
{
printf("FATAL - FAILED TO REALLOC BUFFER!!!\n");
return; //@TODO: We don't really have a good way of dealing with this
}
}
buffer[lineLength++] = c;
}
buffer[lineLength] = '\0';- This code was also wrapped to terminate after 6 lines
- Unfortunately, using
char cis incorrect, as that causes theEOFcomparison to fail - As a result of this, the extractor will continue to reallocate until it OOMs and crashes the scanner, leading to the symptom of a scriptlet not appearing
- This was switched to
int cwhich fixed the bug
The crash dumps
- It is still unknown why the sh_integration syslog function was causing constant scanner crashes
- It has been removed in v2.3.1 for this reason
Why didn't tests catch this?
- Unknown, neither of these issues happened on my laptop for some reason
- Let me know if you do know though
v2.3.0 - The one that explodes your storage
- Fixes sh_integration (FINALLY)
v2.2.5c
Too lazy to bump version, fixes ;kmclog
v2.2.5b
We implemented moar logging + sh_integration update again maybe this time it works idk
We added a brand new ;kmclog command - use it when reporting errors