Open
Conversation
Adds a function that loads a filename (Should have the list of repos urls in it) and then loads each one. It then calls the origional fetch function on each of the repo urls and loads all of those.
Init() was no longer needed, as it was only used on the document start and can be replaced with the new load function
it was used all over, so i just moved it out.
I figured it would make refactoring easier in the future. I wanted it so I didn't have to pass the url into the loadAll function every time or "hard code" it
I checked the discord roadmap, and thats what its named there. It doesn't matter much.
It searches all repos instead of the hardcoded one
Move the fetchallrepositories stage to after the check for the file runs.
Should've been parsing by newline. Nothing was showing up on screen because the main repo got split into two urls, both invalid.
Author
|
I didn't actually make 355 additions and 272 removals; my editor automatically formats the Go on save. It mostly happened in commit 29a56b5, so changes before and after shouldn't be so bad to read. Sorry. |
Collaborator
|
I will look over this soon |
Author
|
I've been thinking about this feature a little, and there doesn't seem to be much use for it. It is fairly easy to get a package into the real repository, and the multiple repository might add unnecessary complexity to the codebase. For those reasons, I'm going to close this PR. |
Collaborator
|
I'll still look over eventually as it was on the roadmap! |
Collaborator
|
? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
checkRepositoryFile(), it checks for the file and creates it if it doesn't exist. This should only really happen on first install. It defaults to the official repo atkf.penguins184.xyz. The file is created at/mnt/us/.KFPM/repositories.txt, next toinstalled.txt. Having the default repo at the top is also good because, in the case of package collisions, it defaults to the first repo, which is the main one.Both the Go and JS sides respect the repo file.
I'd like to hear comments or changes that need to be made, if any.