Open
Conversation
nodchip
reviewed
May 26, 2024
| ```python | ||
| class Solution: | ||
| def majorityElement(self, nums: List[int]) -> int: | ||
| cnt_nums = {} |
There was a problem hiding this comment.
https://discord.com/channels/1084280443945353267/1192728121644945439/1244281685818740737
をご覧ください。
今回の場合は、 num_to_count あたりがよいと思います。
| class Solution: | ||
| def majorityElement(self, nums: List[int]) -> int: | ||
| cnt_nums = {} | ||
| nums_len = len(nums) |
There was a problem hiding this comment.
nums_len ですと len(nums) からあまり変わっていないように思いますので、変数に代入する必要はないと思います。
| cnt_nums = {} | ||
| nums_len = len(nums) | ||
| for num in nums: | ||
| cnt_nums[num] = cnt_nums.get(num,0) + 1 |
There was a problem hiding this comment.
| nums_len = len(nums) | ||
| for num in nums: | ||
| cnt_nums[num] = cnt_nums.get(num,0) + 1 | ||
| if cnt_nums[num] > nums_len//2: |
There was a problem hiding this comment.
// の左右にスペースを空けましょう。
https://peps.python.org/pep-0008/#other-recommendations
oda
reviewed
May 27, 2024
| class Solution: | ||
| def majorityElement(self, nums: List[int]) -> int: | ||
| cnt_nums = defaultdict(int) | ||
| num_len = len(nums) |
There was a problem hiding this comment.
私はこの変数は作らないかしら。
趣味の問題ですが登場人物を増やして増える複雑性と名前をつけることによって減る複雑性が釣り合っていないのではないかと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/majority-element/