Open
Conversation
nodchip
reviewed
May 26, 2024
| # self.next = next | ||
| class Solution: | ||
| def isPalindrome(self, head: Optional[ListNode]) -> bool: | ||
| val_list = [] |
There was a problem hiding this comment.
https://discord.com/channels/1084280443945353267/1192728121644945439/1244281685818740737
をご参照ください。
また、型が list であることが分かっているため、変数名に list を入れる必要はないと思います。 values あたりがよいと思います。
Comment on lines
+18
to
+22
| val_list.append(head.val) | ||
|
|
||
| while head and head.next: | ||
| head = head.next | ||
| val_list.append(head.val) |
There was a problem hiding this comment.
head はリストの最初のノードを表します。 head を動かしている点に違和感を感じました。 node などの変数に一度代入し、 node を動かしていくとよいと思います。
また、リストの辿り方がやや複雑に感じました。
node = head
while node:
val_list.append(node.val)
node = node.next
のほうがシンプルだと思います。
There was a problem hiding this comment.
ループの先頭で、不必要に主役が変更されています。
また、head and head.next の head は不要では?
| while head and head.next: | ||
| head = head.next | ||
| val_list.append(head.val) | ||
| left = 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/palindrome-linked-list/