Refactor f kernel by KitsuneSemCalda · Pull Request #14 · KitsuneBSD/FKernel

KitsuneSemCalda · 2025-11-09T23:44:46Z

No description provided.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security · 2025-11-09T23:46:48Z

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security

Flawfinder (reported by Codacy)-0-19216266616 found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

TODO.md

+
+- [ ] Create a Adapter class to `BlockDevice`
+
+- [x] Create a base class **Hardware Interrupt** to be inherited by ([8259Pic](https://en.wikipedia.org/wiki/Intel_8259) / [APIC](https://en.wikipedia.org/wiki/Advanced_Programmable_Interrupt_Controller) ...)


TODO.md

+- [ ] Create a Adapter class to `BlockDevice`
+
+- [x] Create a base class **Hardware Interrupt** to be inherited by ([8259Pic](https://en.wikipedia.org/wiki/Intel_8259) / [APIC](https://en.wikipedia.org/wiki/Advanced_Programmable_Interrupt_Controller) ...)
+- [x] Create a base class **Timer** to be inherited by ([PIT](https://en.wikipedia.org/wiki/Programmable_interval_timer), [APIC Timer](https://en.wikipedia.org/wiki/Advanced_Programmable_Interrupt_Controller#APIC_timer) ...)


TODO.md

+  - [ ] Enforce memory protection between user processes and kernel.
+
+- [ ] **Advanced Memory Management:**
+  - [ ] Implement kernel heap for dynamic allocations (already has TLSFHeap, but ensure it's robust).


TODO.md

+
+- [ ] **File System Enhancements:**
+  - [ ] Implement a real disk filesystem (e.g., FAT32, ext2/3/4).
+  - [ ] Extend VFS with full POSIX file operations (e.g., `stat`, `link`, `unlink`, `mkdir`, `rmdir`).


TODO.md

+  - [ ] Implement a basic network driver (e.g., for a virtual NIC in QEMU).
+  - [ ] Implement a basic USB driver.
+
+### Toolchain


github-advanced-security

Remark-lint (reported by Codacy)-18-19216266616 found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Include/Kernel/Arch/x86_64/Interrupt/HardwareInterrupts/InterruptController/apic.h

+  uintptr_t lapic_base = 0;       ///< Mapped LAPIC base
+  uint64_t apic_ticks_per_ms = 0; ///< Timer ticks per ms
+
+  uint32_t read(uint32_t reg);


Include/Kernel/Arch/x86_64/Interrupt/HardwareInterrupts/InterruptController/ioapic.h

+
+  String m_name = "IOAPIC";
+
+  uint32_t read(uint32_t reg);


Include/Kernel/Block/partition_device.h

+                          ///< (heap-allocated)
+  uint32_t lba_first;     ///< LBA of the first sector of the partition
+  uint32_t sectors_count; ///< Total number of sectors in the partition
+  uint8_t type; ///< Partition type identifier (e.g., MBR partition type)


Include/Kernel/Block/partition_device.h

+   * @param offset Offset in the partition to start reading from
+   * @return Number of bytes read on success, negative error code on failure
+   */
+  static int read(VNode *vnode, FileDescriptor *fd, void *buffer, size_t size,


Include/Kernel/Driver/Ata/AtaBlockDevice.h

-    static int write(VNode *vnode, FileDescriptor *fd, const void *buffer, size_t size, size_t offset);
+/**
+ * @brief Block device interface for ATA devices
+ *


Include/Kernel/FileSystem/VirtualFS/vnode.h

+   * @param flags Open flags.
+   * @return 0 on success or negative on error.
+   */
+  inline int open(FileDescriptor *fd, int flags) {


Include/Kernel/FileSystem/VirtualFS/vnode.h

+   * @return 0 on success or negative on error.
+   */
+  inline int open(FileDescriptor *fd, int flags) {
+    int ret = ops && ops->open ? ops->open(this, fd, flags) : 0;


Include/LibFK/Container/string.h

+inline String operator+(const String& lhs, const char* rhs) {
+    if (!rhs) return lhs;
+    String result;
+    result.reserve(lhs.length() + strlen(rhs) + 1);


Include/LibFK/Container/string.h

+inline String operator+(const char* lhs, const String& rhs) {
+    if (!lhs) return rhs;
+    String result;
+    result.reserve(strlen(lhs) + rhs.length() + 1);


Include/LibFK/Container/string_view.h

+     * @param s Null-terminated C-style string.
+     */
+    constexpr StringView(const char* s) noexcept
+        : m_data(s), m_size(s ? strlen(s) : 0) {}


…n use any timer

KitsuneSemCalda added 30 commits November 3, 2025 15:17

refactor(interrupthandler): use LibFK instead LibC

aa2df92

refactor(pit): use doxygen

ee80c93

refactor(handlers): use LibFK/Types/types.h

0357cb9

refactor(interrupt): use LibFK/Types/types.h

ebb436c

refactor(gdt): use LibFK/Types/types.h

0fe8da6

docs(arch_defs): use doxygen for each defines

7cbe0aa

refactor(io): use LibFK/Types/types.h

26060c7

feat(gdt): implement segment config

194b902

docs(block): use doxygen to manage partitions

1c6d648

chore(memory map): remove memory map

f7b9110

docs(multiboot2): add doxygen

24bcd63

chore(early_init): use memory_map

8a141dc

docs(ata): use doxygen

f83be80

docs(devices): use Doxygen to be a docs

229cd41

docs(keyboard): add doxygen docs

3dc95ba

docs(serial_port): add doxygen docs

55493d0

docs(vga): add doxygen docs

3d75179

docs(vga): add doxygen-docs

2bbfb0f

refactor(libfk): use types/types.h

eb6a41b

refactor(libfk): use types/types.h instead LibC

0b2e195

refactor(libfk): types/types.h instead LibC

cdef6f4

docs(kernel): add doxygen-docs

b956058

fix(apic timer): now we can use properly the apic to make things work

7c8661e

refactor(move): remove new/cxxabi -> Memory/

c6db13b

feat(ioapic): add support to IOAPIC

e576e88

refactor(8259pic): improve message

4c1dbe8

refactor(cpu): improve message

6366ccc

refactor(logs): remove kdebug on alloc_page

594410d

refactor(pit): use %lu instead %llu

5fee5b7

fix(vgabuffer): vga now can write on ega properly

7c483c6

github-advanced-security bot found potential problems Nov 9, 2025

View reviewed changes

KitsuneSemCalda added 11 commits November 9, 2025 20:47

fix(ioapic): ioapic_base need receive ioapic_address

7682ff0

feat(libfk): add on crc32 hash on LibFK

b8a9d77

refactor(traits): use crc32 on x86_64 and djb2 on general archictetures

1178ea9

feat(timercontroller): use strategy patern to select between Timers

afe3365

refactor(message): use selected instead the all message before

dacd602

feat(timerinterrupt): apply a strategy pattern to dynamically set whe…

ffdbbaa

…n use any timer

feat(rtc): add support to RTC Timer

cfb741f

feat(interruptcontroller): add support to x2APIC

afbfff6

chore(gemini): configure gemini-cli

f99e353

chore(todo): update TODO

62e83c9

Merge branch 'feature/init' into refactor-FKernel

abe71b8

KitsuneSemCalda closed this Nov 9, 2025

KitsuneSemCalda deleted the refactor-FKernel branch November 9, 2025 23:55


		- [ ] Create a Adapter class to `BlockDevice`

		- [x] Create a base class Hardware Interrupt to be inherited by ([8259Pic](https://en.wikipedia.org/wiki/Intel_8259) / [APIC](https://en.wikipedia.org/wiki/Advanced_Programmable_Interrupt_Controller) ...)

Conversation

KitsuneSemCalda commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot commented Nov 9, 2025

Uh oh!

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Check warning

Check warning

Check warning

Check warning

Check notice

github-advanced-security bot left a comment

Choose a reason for hiding this comment

Uh oh!

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Check failure

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant