You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should be finished. I created a C shared lib binding, the Ruby binding that uses the C shared lib, and decoupled the portaudio stuff in to an optional tool provided by the ruby binding, allowing for other audio data sources
@ppibburr thanks for the PR. Two high level comments:
Could you move bindings/C to swig/Ruby/C, and then bindings/Ruby to swig/Ruby? I know you are not using the software swig, but swig also means Simplified Wrapper and Interface Generator, so we'll keep using that directory for creating wrappers.
Could you make files snowboy-detect-c-wrapper.{h,cc} (and other files if you copy them over) soft links instead of hard copies? This way, when we do update, we only have to update one source code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a ruby wrapper with FFI around the C portaudio example, using it as a sharedlib instead of a binary.
Also a standalone repo can be found here.
ruby-snowboy
Compiles pretty straight forward on Ubuntu Xenial 64bit