Resolved creation of dynamic property Gaufrette\StreamWrapper:: is de… #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thx for your PR. |
|
bump |
|
bump |
|
Any updates? |
|
bump |
zen1t
approved these changes
Jun 25, 2024
edhgoose
added a commit
to edhgoose/Gaufrette
that referenced
this pull request
Jul 17, 2024
cedricvazille
approved these changes
Jul 20, 2024
cedricvazille
left a comment
cedricvazille
left a comment
There was a problem hiding this comment.
This change solve the problem on my project, so I think this line is necessary.
dany-loveevents
approved these changes
Oct 11, 2024
dany-loveevents
left a comment
dany-loveevents
left a comment
There was a problem hiding this comment.
This change solve the problem on my project
apsylone
approved these changes
Dec 9, 2024
Contributor
|
Any news on a possible merge? |
Contributor
|
Any news again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the knplabs/knp-gaufrette-bundle:v0.8.0 library
Since I have upgraded php version from 8.1 to 8.2 I am getting a deprecated warning "Deprecated: Creation of dynamic property Gaufrette\StreamWrapper::$context is deprecated in .../vendor/symfony/http-foundation/BinaryFileResponse.php on line 199" when returning the file in a controller:
return new BinaryFileResponse('gaufrette://foo/hello.txt');I've added the public context property to the GaufretteStreamWrapper object as per the native class specification in php:
https://www.php.net/streamwrapper
With this change the code works perfectly, as it does not access the $context property dynamically.
If you think it is convenient I would like to add this change to the library.
Thanks