-
Notifications
You must be signed in to change notification settings - Fork 2
Solved issue #5 sound effects #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for your contribution :)
That's a pretty good job, but I would like you to fix the problems that I pointed out in the review
To make it more clear:
- make sure that no errors appear in the console
- remove old code in the comments
- changes to
package-lock.json,package.jsonandyarn.lockare redundant - we don't need two versions of each sound mp3 is enough
|
@KonradLinkowski did the requested changes except for the button please review it. |
|
@sanket95droid hey, please remove changes to |
|
@KonradLinkowski ok, should I also remove changes to |
|
@sanket95droid yes I fixed the issue you mentioned earlier about |
|
@KonradLinkowski please compare and merge my PR!! |
|
@sanket95droid I can't merge it because you didn't resolve the conflicts. |
|
Ohk i'll try to resolve those conflits and make a commit @KonradLinkowski |
@KonradLinkowski Done ✅ |
Used Three.js Audio section for adding audio :