Remove deprecated and unused access api examples and migrate multi-column add/map #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
changed the title
koperagen
force-pushed
the
remove-unused-access-api-examples
branch
from
7dcc56e to
4d44edf
Compare
| configuration = SamplesDisplayConfiguration.copy( | ||
| cellFormatter = { row, col -> | ||
| val value = row[col] | ||
| val value = col[row] |
AndreiKingsley
approved these changes
Dec 19, 2025
Jolanrensen
reviewed
Dec 19, 2025
| * For more information: {@include [DocumentationUrls.AccessApis.ExtensionPropertiesApi]} | ||
| * | ||
| * For example: {@comment This works if you include the test module when running KoDEx} | ||
| * For example, in notebooks extension properties are generated from runtime data after the cell is executed: {@comment This works if you include the test module when running KoDEx} |
Collaborator
There was a problem hiding this comment.
You can put the @comment on the next line, if you write it without {}, there should be no newline in between executed: and @sample
Jolanrensen
reviewed
Dec 19, 2025
| "year of birth" from 2021 - "age"<Int>() | ||
| "age"<Int>() gt 18 into "is adult" | ||
| "year of birth" from { 2021 - "age"<Int>() } | ||
| expr { "age"<Int>() > 18 } into "is adult" |
Collaborator
There was a problem hiding this comment.
maybe we could alternate with other, more kotlinlike notations, such as "age<Int>().map { it > 18 } into "is adult"
Collaborator
There was a problem hiding this comment.
I do like we have more expr examples :) Feels like the concept is not well known
Jolanrensen
reviewed
Dec 19, 2025
| } | ||
|
|
||
| fun DataFrame<Person>.countAdults() = count { it[Person::age] > 18 } | ||
| fun DataFrame<Person>.countAdults() = count { it.age > 18 } |
Collaborator
There was a problem hiding this comment.
doesn't need it right?
Jolanrensen
approved these changes
Dec 19, 2025
Collaborator
Jolanrensen
left a comment
Jolanrensen
left a comment
There was a problem hiding this comment.
Thanks! A very welcome cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're already not used on the website for a while.