add config option to change the setImmediate time usage to improve performance#28
Open
Trickfilm400 wants to merge 2 commits intoKrb686:masterfrom
Open
add config option to change the setImmediate time usage to improve performance#28Trickfilm400 wants to merge 2 commits intoKrb686:masterfrom
Trickfilm400 wants to merge 2 commits intoKrb686:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
add a new config parameter to the constructor to add a value to change the 25ms value which will be used to decide whether to use setTimeout or setInterval
We had an usecase with an interval of les than 24ms which needed to be accurate and the CPU usage was by 100% because of this - with the value changed to 5ms the performance was better