This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Mixed return type includes null #31
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents appending
?to nullable return types if the return type ismixedbecausemixedalready includes null. Appending the?causes php-lint to complain. For now, I've just excluded_ide_macros.phpfrom php-lint in CI so this is low-impact for me. But it might be helpful to others.I'm not sure this solution is 100% complete. I haven't read the code carefully enough to see how pipe-joined mixed return types are handled and what would happen if the return type were something like
string|int|null. Obviously in that case, the?should also not be appended. Let me know if you think that's something that I should explore further.Thanks for the great package! It's made my life a whole lot easier.