Skip to content

Conversation

@jihchao
Copy link

@jihchao jihchao commented Aug 25, 2023

Add a callback for dismiss, notifying the caller to perform logic, such as animation.

@jihchao
Copy link
Author

jihchao commented Aug 25, 2023

@shliama shliama requested a review from klnfreedom October 25, 2023 07:13
Copy link
Collaborator

@klnfreedom klnfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good idea to add a callback function when a sheet has been closed but change the name of this one.

required this.position,
required this.dismissible,
required this.decorationBuilder,
this.dismissCallback,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the name of the function onDismissCallback

required bool dismissible,
required int index,
bool initWithAnimation = true,
Function? dismissCB,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the name of the function onDismissCallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants