-
-
Notifications
You must be signed in to change notification settings - Fork 0
chore: introduce Turborepo build caching #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5276329 to
b5e19f5
Compare
Summary of ChangesHello @KubrickCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the project's build and development efficiency by integrating Turborepo for task-level caching. The changes involve setting up pnpm workspaces, configuring Turborepo's task pipelines, and updating existing scripts to utilize this new caching mechanism. The primary goal is to drastically reduce build, test, and lint times, both locally and in CI environments, by avoiding redundant work and leveraging cached results. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Turborepo to enable build caching, which is a great step for improving local and CI performance. The changes correctly set up the pnpm workspace, add Turborepo configuration, and update .gitignore and .vscodeignore files. My review focuses on ensuring the new Turborepo setup is correctly configured and fully leveraged. I've identified a critical issue with the lint script that would cause it to fail, and a high-severity issue where the build script doesn't cache the entire build process, missing a key optimization opportunity. I've also included a suggestion to make the turbo.json configuration more robust and maintainable.
b5e19f5 to
6e9c6fc
Compare
full builds on every local and CI run wasted significant time. enabled task-level caching with turbo@2.6.1 and pnpm workspace setup - pnpm-workspace.yaml: define extension, view packages - turbo.json: configure build, test, lint pipelines - add turbo cache settings to GitHub Actions - add turbo-related files to .vscodeignore exclusions subsequent builds with cache hit reduced from 9s to 60ms fix #199
6e9c6fc to
02bf222
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Turborepo for build caching, which is a great step towards improving build performance. The overall setup is solid. I've provided a few suggestions to enhance the maintainability and robustness of the configuration files. Specifically, I've recommended refactoring some npm scripts in src/extension/package.json to avoid brittle cd commands and suggested making the turbo.json configuration more concise by removing duplication, in line with the repository's style guide.
full builds on every local and CI run wasted significant time. enabled task-level caching with turbo@2.6.1 and pnpm workspace setup
subsequent builds with cache hit reduced from 9s to 60ms
fix #199