Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Oct 15, 2025

WHAT

  • add decrypt-and-combine Lit Action e2e coverage
  • document the pnpm test:custom -- --runTestsByPath workflow for custom specs (basically anything but e2e.spec.ts)
  • add lightweight initFast bootstrapping for ticket specs and restructure executeJs helpers. It speeds up test iteration by skipping heavy setup while sharing executeJs helpers across suites

Relevant PRs

❗️Blocked ✅ UPDATED 28, Oct, 2025

This is blocked until Lit.Actions.encrypt returns data in Base64 format instead of a raw JSON string.

@Ansonhkg Ansonhkg self-assigned this Oct 15, 2025
Copilot AI review requested due to automatic review settings October 15, 2025 14:50
@Ansonhkg Ansonhkg added documentation Improvements or additions to documentation Feature testing v8 | Naga labels Oct 15, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds end-to-end test coverage for the decryptAndCombine Lit Action and introduces a lightweight initFast initialization mode to speed up test iteration for custom ticket specs.

  • Adds comprehensive e2e test for decryptAndCombine Lit Action functionality
  • Implements initFast mode that skips PKP setup for faster test bootstrapping
  • Refactors executeJs test helpers into modular structure with shared context types
  • Documents workflow for running individual ticket specs using --runTestsByPath

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/e2e/src/tickets/drel1157-la-decryptandcombine.spec.ts New test spec that validates decryptAndCombine Lit Action using fast init mode
packages/e2e/src/init.ts Refactored to support both full and fast initialization modes with shared base setup
packages/e2e/src/helper/tests/index.ts Updated exports to reflect renamed and new executeJs test functions
packages/e2e/src/helper/tests/executeJs/index.ts New barrel export file for modular executeJs test helpers
packages/e2e/src/helper/tests/executeJs/decrypt-and-combine.ts New test helper implementing decryptAndCombine Lit Action validation
packages/e2e/src/helper/tests/executeJs/basic.ts Refactored from execute-js.ts with improved type safety and error handling
packages/e2e/src/e2e.spec.ts Updated to use renamed executeJs test functions and added decryptAndCombine test case
README.md Added documentation for running custom ticket specs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Ansonhkg Ansonhkg changed the title Feature/drel 1157 discord timeout with decryptandcombine feat(test): Feature/drel 1157 discord timeout with decryptandcombine Oct 15, 2025
@Ansonhkg Ansonhkg added the Blocked stalled due to external dependencies, unresolved issues, or waiting on input from other teams or con label Oct 15, 2025
@Ansonhkg
Copy link
Collaborator Author

lit-asset pr to follow https://github.com/LIT-Protocol/lit-assets/pull/2284/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Blocked stalled due to external dependencies, unresolved issues, or waiting on input from other teams or con documentation Improvements or additions to documentation Feature testing v8 | Naga

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants