-
Notifications
You must be signed in to change notification settings - Fork 87
feat(test): Feature/drel 1157 discord timeout with decryptandcombine #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: naga
Are you sure you want to change the base?
feat(test): Feature/drel 1157 discord timeout with decryptandcombine #955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds end-to-end test coverage for the decryptAndCombine Lit Action and introduces a lightweight initFast initialization mode to speed up test iteration for custom ticket specs.
- Adds comprehensive e2e test for
decryptAndCombineLit Action functionality - Implements
initFastmode that skips PKP setup for faster test bootstrapping - Refactors executeJs test helpers into modular structure with shared context types
- Documents workflow for running individual ticket specs using
--runTestsByPath
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/e2e/src/tickets/drel1157-la-decryptandcombine.spec.ts | New test spec that validates decryptAndCombine Lit Action using fast init mode |
| packages/e2e/src/init.ts | Refactored to support both full and fast initialization modes with shared base setup |
| packages/e2e/src/helper/tests/index.ts | Updated exports to reflect renamed and new executeJs test functions |
| packages/e2e/src/helper/tests/executeJs/index.ts | New barrel export file for modular executeJs test helpers |
| packages/e2e/src/helper/tests/executeJs/decrypt-and-combine.ts | New test helper implementing decryptAndCombine Lit Action validation |
| packages/e2e/src/helper/tests/executeJs/basic.ts | Refactored from execute-js.ts with improved type safety and error handling |
| packages/e2e/src/e2e.spec.ts | Updated to use renamed executeJs test functions and added decryptAndCombine test case |
| README.md | Added documentation for running custom ticket specs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
lit-asset pr to follow https://github.com/LIT-Protocol/lit-assets/pull/2284/files |
WHAT
decrypt-and-combineLit Action e2e coveragepnpm test:custom -- --runTestsByPathworkflow for custom specs (basically anything but e2e.spec.ts)initFastbootstrapping for ticket specs and restructure executeJs helpers. It speeds up test iteration by skipping heavy setup while sharing executeJs helpers across suitesRelevant PRs
❗️Blocked✅ UPDATED 28, Oct, 2025This is blocked until
Lit.Actions.encryptreturns data in Base64 format instead of a raw JSON string.