Expand detection of MSVC #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPILER_FAMILY_IS_MSVC was set according to detected build tools, but may have missed some (such as Ninja, which is available for Windows). CMake sets MSVC=1 when an MSVC compatible compiler is detected. It is possible that some versions of CMake might not set MSVC=1 in all cases when it should, but it is hard to imagine a false positive, so using two checks for COMPILER_FAMILY_IS_MSVC seems fair.
white238
approved these changes
Oct 29, 2025
Member
white238
left a comment
white238
left a comment
There was a problem hiding this comment.
Thanks @eirrgang ! Waiting on @kennyweiss to weigh in because he does the Axom Windows builds.
eirrgang
commented
Oct 30, 2025
Co-authored-by: M. Eric Irrgang <vardarirrgan1@llnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPILER_FAMILY_IS_MSVC was set according to detected build tools, but may have missed some (such as Ninja, which is available for Windows). CMake sets MSVC=1 when an MSVC compatible compiler is detected. It is possible that some versions of CMake might not set MSVC=1 in all cases when it should, but it is hard to imagine a false positive, so using two checks for COMPILER_FAMILY_IS_MSVC seems fair.