Skip to content

Alphabet and param scan dev#89

Open
billy000400 wants to merge 2 commits intomainfrom
alphabet_param_scan_billy
Open

Alphabet and param scan dev#89
billy000400 wants to merge 2 commits intomainfrom
alphabet_param_scan_billy

Conversation

@billy000400
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can make this directly more general to deal with vbf as well? like introduce a notion of signal_base or something similar. but otherwise lgtm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we could maybe just make utils.extract_base_signal_key a bit smarter

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this by accident?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here, why do you want to ignore userConfig.py?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similarly as for userConfig.py, not sure what the best practice is in this case. Don't mind approving it but it is not very clean maybe? we could e.g. just add a commented line for the different paths for all users in the usual MakeTemplates.sh?

if [[ "$unblinded" == "True" ]]; then
run_unblinded_hh4b.sh --workspace --bfit --passbin=0
else
run_blinded_hh4b.sh --workspace --bfit --passbin=0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you that the script works as it does, but where is the file run_blinded_hh4b.sh?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused as to why we need this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants