issue/591/triaxiality: Build scripts in examples/triaxiality #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenmingfu
changed the title
shenmingfu
changed the title
... using equations 31-38 from Tae-hyeon's paper (https://academic.oup.com/mnras/article/475/2/2421/4788804)
... also adding const plots
Comparison of Tae's and Adhikari's implementations of quadrupole and monopole components
Includes fitting for orientation of halo and ellipticity simultaneously.
…to separate functions
15 tasks
m-aguena
requested changes
Oct 17, 2025
clmm/clusterensemble.py
Outdated
| cross_component_out, | ||
| weights_out, | ||
| ) | ||
| if self.include_quadrupole: |
Member
There was a problem hiding this comment.
@shenmingfu but doesn't the self.include_quadrupole=False attribute makes the quadrupole computation be avoided aways?
Removed the redundant condition to check if `self.include_quadrpole` is set to be `True` in `make_individual_radial_profile()` function. This is being checked in `add_individual_radial_profile()` and is unnecessary here.
Incorporated suggestions on code-formatting
Incorporated code-formatting suggestions
Incorporated code-formatting suggestions
Incorporated code-formatting suggestions
Incorporated code-formatting suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#591