LibWeb: Get some easy StructuredSerialize subtests passing #7307
+49
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
CountBleck
force-pushed
the
structured-clone-fixes
branch
from
c798ba1 to
a3cdf1b
Compare
github-actions
bot
added
the
conflicts
|
Your pull request has conflicts that need to be resolved before it can be reviewed and merged. Make sure to rebase your branch on top of the latest |
The spec doesn't include this behavior (at least, not yet), but all browsers do this, as can be seen in several subtests in https://wpt.live/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
When a "length-tracking" TypedArray/DataView is postMessage'd, the view seen by the recipient should still be "length-tracking". However, this wasn't the case, because the actual length was serialized, as opposed to the JS::ByteLength, which includes the "auto" state to signal the presence of this "length-tracking" behavior. This fixes two subtests in... https://wpt.live/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html
This just re-imports the file via WPT.sh to match what is currently present in WPT. This file is used by... https://wpt.live/html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html ...as well as other WPT tests.
CountBleck
force-pushed
the
structured-clone-fixes
branch
from
a3cdf1b to
f81af74
Compare
github-actions
bot
removed
the
conflicts
shannonbooth
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
Error#causeand the byte lengths ofTypedArrays are properly serialized viastructuredClone/StructuredSerialize. I also updated the part of the WPT test (html/infrastructure/safe-passing-of-structured-data/messagechannel.any.html) that wasn't passing on the live version but was passing in our imported version. Combined with #7306 (which fixes one subtest), this PR actually gets all subtests in that test to pass.