LibJS: Don't skip indexed property storage switching in Array fast path #7366
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's harmless if the WeakRef is asked to remove dead cells when it has no dead cells to remove. This can happen if the WeakRef lives longer due to someone referencing it. Caught by test-js with different GC frequency.
If we call put() directly on the underlying indexed property storage like we were doing here, we skip the checks that switch from flat to sparse property storage when a huge index is suddenly accessed. This was caught by folks hitting memory issues when running test-js.
trflynn89
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we call
put()directly on the underlying indexed property storage like we were doing here, we skip the checks that switch from flat to sparse property storage when a huge index is suddenly accessed.This was caught by folks hitting memory issues when running
test-js.Fixes #7365