feat: enable AskQuestion tool by default#281
Merged
shuv1337 merged 2 commits intointegrationfrom Jan 7, 2026
Merged
Conversation
Remove experimental flag gating for the AskQuestion tool so it's available to all users without configuration. Update documentation and fork-features.json to reflect this change.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -977,7 +977,6 @@ export namespace Config { | |||
| chatMaxRetries: z.number().optional().describe("Number of retries for chat completions on failure"), | |||
| disable_paste_summary: z.boolean().optional(), | |||
| batch_tool: z.boolean().optional().describe("Enable the batch tool"), | |||
There was a problem hiding this comment.
style: Run ./script/generate.ts to regenerate the SDK - the auto-generated file packages/sdk/js/src/v2/gen/types.gen.ts still contains the askquestion_tool field that was removed here
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/opencode/src/config/config.ts
Line: 979:979
Comment:
**style:** Run `./script/generate.ts` to regenerate the SDK - the auto-generated file `packages/sdk/js/src/v2/gen/types.gen.ts` still contains the `askquestion_tool` field that was removed here
How can I resolve this? If you propose a fix, please make it concise.…ion to sync SDK types with config schema change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the AskQuestion tool by default, removing the experimental flag requirement.
Changes
Features
experimental.askquestion_toolconfig option from schemaDocumentation
Files Changed
packages/opencode/src/tool/registry.ts- Include AskQuestionTool unconditionallypackages/opencode/src/config/config.ts- Remove askquestion_tool from experimental configREADME.md- Update documentationscript/sync/fork-features.json- Update feature documentationBreaking Changes
None. Users who had
experimental.askquestion_tool: trueconfigured will see no change. The config option is simply no longer required.Testing
Existing tests pass. The AskQuestion tool tests in
packages/opencode/test/continue to work.Greptile Summary
This PR promotes the AskQuestion tool from experimental to default-enabled status, removing the need for manual configuration. The changes properly remove the conditional logic in the tool registry and the experimental config flag from the schema.
experimental.askquestion_toolconfig option from the Zod schemaregistry.tsfork-features.jsondocumentation to reflect new statusThe implementation is clean and straightforward - users who had the experimental flag enabled will see no behavioral change, while others will now have the tool available automatically.
Confidence Score: 4/5
packages/opencode/src/config/config.ts- needs SDK regeneration after mergeImportant Files Changed
Sequence Diagram
sequenceDiagram participant User participant Registry as ToolRegistry participant Config as Config Schema participant AskQuestion as AskQuestionTool Note over Registry,Config: Before PR (experimental flag) User->>Config: Reads opencode.json Config-->>User: experimental.askquestion_tool = true/false User->>Registry: Initialize tools Registry->>Config: Check experimental.askquestion_tool alt askquestion_tool === true Registry->>AskQuestion: Register AskQuestionTool Registry-->>User: Tools with AskQuestion else askquestion_tool !== true Registry-->>User: Tools without AskQuestion end Note over Registry,Config: After PR (default enabled) User->>Config: Reads opencode.json Note over Config: askquestion_tool removed from schema User->>Registry: Initialize tools Registry->>AskQuestion: Register AskQuestionTool unconditionally Registry-->>User: Tools with AskQuestion (always)