π (rn-ble) [NO-ISSUE]: Fix BLE scan first emission delay#1308
Draft
OlivierFreyssinet wants to merge 1 commit intodevelopfrom
Draft
π (rn-ble) [NO-ISSUE]: Fix BLE scan first emission delay#1308OlivierFreyssinet wants to merge 1 commit intodevelopfrom
OlivierFreyssinet wants to merge 1 commit intodevelopfrom
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Description
Fixes a ~1 second delay before the first scanned BLE device appears in
listenToAvailableDevices().Root cause: In
_startScanning(), the inner subject was aBehaviorSubject([])which immediately emitted an empty[]. This consumed the leading edge ofthrottleTime(1000), opening a 1s window that dropped the first real scan results. The first scanned device only appeared after the throttle window expired (~1s).Fix: Replaced
BehaviorSubject<InternalScannedDevice[]>([])withReplaySubject<InternalScannedDevice[]>(1)for the inner scan subject.ReplaySubject(1)buffers the last value likeBehaviorSubject(needed because the scan callback fires synchronously beforeswitchMapsubscribes to the returned observable) but has no initial emission, so the first real scan result passes throughthrottleTimeimmediately as the leading edge.BehaviorSubject's initial emission) and polled every ~1s via the existingsetInterval.β Context
β Checklist
Made with Cursor