✨ (cs-tester) [NO-ISSUE]: Detect and handle intermediate blind signing screens#1333
Draft
aussedatlo wants to merge 4 commits intodevelopfrom
Draft
✨ (cs-tester) [NO-ISSUE]: Detect and handle intermediate blind signing screens#1333aussedatlo wants to merge 4 commits intodevelopfrom
aussedatlo wants to merge 4 commits intodevelopfrom
Conversation
Add screen-aware navigation to the signing flow that detects and handles three intermediate screens: "safer way to sign", "blind signing ahead", and "blind signing not enabled". Includes gating screen test resource and nightly CI job. Made-with: Cursor
Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
aussedatlo
force-pushed
the
feat/no-issue-gating-cs-tester
branch
from
66fe9fc to
59bfd47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Add screen-aware navigation to the clear-signing tester's signing flow. The navigation loop now detects and correctly handles three intermediate screens that can appear before the transaction review fields:
Also tightens
isBlindSigningWarning()detection to avoid false matches across these screens (the substring"blind signing"appears in all three).Includes:
ressources/gating/raw-gating-screen.json) with 11 identical transactionstest:gating-screennpm script with--blind-signing-enabled --skip-origin-tokengating-testsjob in the ERC7730 nightly workflow (stax, nanox, flex)❓ Context
✅ Checklist
ScreenAnalyzer(isContinueToBlindSigningScreen,isBlindSigningBlocked)continueToBlindSigning()method inDeviceControllerinterface and implementationsSignTransactionStateHandlerto handle intermediate screensisBlindSigningWarning()to only match "blind signing ahead" (no longer matches "continue to blind signing")Made with Cursor