Merged
Conversation
Collaborator
gamegee
commented
Mar 18, 2026
gamegee
commented
- chore: update app-sandbox-rnative versions
- test(ui-rnative): make sure to test the ThemeProvider with real components that consume the theme
Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr>
…nents that consume the theme Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the React Native sandbox app to consume newer Lumen design system packages, and adjusts a ThemeProvider render test to use the real theme set and a broader set of UI components.
Changes:
- Bumped
@ledgerhq/lumen-design-coreto0.1.5and@ledgerhq/lumen-ui-rnativeto0.1.11for the RN sandbox app. - Updated the lockfile to reflect the new dependency versions/workspace resolutions.
- Updated
ThemeProvidertest to render withledgerLiveThemesand several representative components.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package-lock.json | Updates locked dependency versions/resolution for the sandbox RN app. |
| libs/ui-rnative/src/lib/Components/ThemeProvider/ThemeProvider.test.tsx | Switches the test to real ledgerLiveThemes and exercises more components under ThemeProvider. |
| apps/app-sandbox-rnative/package.json | Bumps Lumen package versions used by the RN sandbox app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
zel-kass
pushed a commit
that referenced
this pull request
Mar 20, 2026
* chore: update app-sandbox-rnative versions Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * test(ui-rnative): make sure to test the ThemeProvider with real components that consume the theme Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
zel-kass
added a commit
that referenced
this pull request
Mar 20, 2026
* feat(MediaCard): add MediaCard component with leading and trailing content support - Introduced MediaCard component to display images with customizable content. - Added MediaCardLeadingContent and MediaCardTrailingContent for flexible layouts. - Updated App.tsx to include MediaCards in the sandbox. - Enhanced internationalization files with new close button labels in multiple languages. - Added tests and documentation for MediaCard component functionality. * feat(ui-rnative): implement MediaCard component with customizable content slots * refactor(MediaCard): simplify component structure by removing leading and trailing content slots * nx release plan * chore(dependencies): bump @ledgerhq/lumen-design-core to 0.1.5 and @ledgerhq/lumen-ui-rnative to 0.1.11 * refactor(MediaCard): replace RadialGradient with LinearGradient and adjust gradient colors for design fidelity * 💄 (figma): Sync Figma Design Tokens & Symbols (#579) * 💄 (figma): Sync Figma Design Tokens & Symbols * fix: remove is-utility: dark Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> --------- Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> Co-authored-by: gamegee <15988848+gamegee@users.noreply.github.com> Co-authored-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * test/add test for themeprovider (#576) * chore: update app-sandbox-rnative versions Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * test(ui-rnative): make sure to test the ThemeProvider with real components that consume the theme Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * feat(design-core): add whiteHover et whitePressed semantic tokens for theme JS (rn) (#580) Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * feat(InteractiveIcon): add appearance prop for customizable icon colors and replace Pressable in MediaCard with new InteractiveIcon * feat(MediaCard): spread props in MediaCardTitle for enhanced flexibility * feat(MediaCard): add interactive close functionality to MediaCard story * refactor(MediaCard): replace ReactNode import with type import for improved type clarity * Dls 634/fix amount display (#584) * fix(amount-display): fix ui-react AmountDisplay baseline issue + add 0.5px more width for each char Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * nx plan Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * fix(ui-react): fix amountdisplay failing test Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> --------- Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> * feat(MediaCard): enhance documentation and update styles for improved layout * feat(MediaCard): update close button behavior and enhance accessibility features * refactor(MediaCard): update image rendering logic and enhance component structure * refactor(MediaCard): streamline component structure and update props handling --------- Signed-off-by: Simon Bruneaud <simon.bruneaud@ledger.fr> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: gamegee <15988848+gamegee@users.noreply.github.com> Co-authored-by: Simon Bruneaud <simon.bruneaud@ledger.fr> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.