feat: create MediaBanner component#582
Merged
aquelemiguel merged 29 commits intomainfrom Mar 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zel-kass
reviewed
Mar 20, 2026
Collaborator
zel-kass
left a comment
zel-kass
left a comment
There was a problem hiding this comment.
Last question, I see that react's version is missing its Figma code connect. Is that intentional ?
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new MediaBanner component to both @ledgerhq/lumen-ui-rnative and @ledgerhq/lumen-ui-react, including Storybook documentation and sandbox usage, to support DLS-595.
Changes:
- Introduce
MediaBanner,MediaBannerTitle, andMediaBannerDescriptioncomponents (React + React Native). - Add unit tests, Storybook stories, and MDX docs for the new component.
- Update the RN sandbox app and bump related dependency versions / version plan.
Reviewed changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.json | Bumps locked versions for lumen dependencies used by the RN sandbox app. |
| apps/app-sandbox-rnative/package.json | Updates @ledgerhq/lumen-* dependency versions to consume the new component release. |
| .nx/version-plans/version-plan-1773939675391.md | Declares patch releases for lumen-ui-rnative and lumen-ui-react. |
| libs/ui-rnative/src/lib/Components/index.ts | Exports the new MediaBanner component entry point. |
| libs/ui-rnative/src/lib/Components/MediaBanner/types.ts | Defines RN MediaBanner* prop types. |
| libs/ui-rnative/src/lib/Components/MediaBanner/index.ts | Barrel export for RN MediaBanner. |
| libs/ui-rnative/src/lib/Components/MediaBanner/MediaBanner.tsx | Implements the RN MediaBanner + subcomponents. |
| libs/ui-rnative/src/lib/Components/MediaBanner/MediaBanner.test.tsx | Adds RN test coverage for rendering and close behavior. |
| libs/ui-rnative/src/lib/Components/MediaBanner/MediaBanner.stories.tsx | Adds RN Storybook stories for usage/truncation/broken image/dismissible variants. |
| libs/ui-rnative/src/lib/Components/MediaBanner/MediaBanner.mdx | Adds RN Storybook MDX documentation page. |
| libs/ui-react/src/lib/Components/index.ts | Exports the new MediaBanner component entry point. |
| libs/ui-react/src/lib/Components/MediaBanner/types.ts | Defines React MediaBanner* prop types. |
| libs/ui-react/src/lib/Components/MediaBanner/index.ts | Barrel export for React MediaBanner. |
| libs/ui-react/src/lib/Components/MediaBanner/MediaBanner.tsx | Implements the React MediaBanner + subcomponents. |
| libs/ui-react/src/lib/Components/MediaBanner/MediaBanner.test.tsx | Adds React test coverage for rendering, close behavior, className, image, and ref. |
| libs/ui-react/src/lib/Components/MediaBanner/MediaBanner.stories.tsx | Adds React Storybook stories for usage/truncation/broken image/dismissible variants. |
| libs/ui-react/src/lib/Components/MediaBanner/MediaBanner.mdx | Adds React Storybook MDX documentation page. |
| apps/app-sandbox-rnative/src/app/blocks/index.ts | Exposes the new MediaBanners sandbox block. |
| apps/app-sandbox-rnative/src/app/blocks/MediaBanners.tsx | Adds a sandbox screen showcasing MediaBanner variants. |
| apps/app-sandbox-rnative/src/app/App.tsx | Renders the new MediaBanners block in the sandbox app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aammami-ledger
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes DLS-595.