-
Notifications
You must be signed in to change notification settings - Fork 77
#280 Upgrade API documentation (Swagger -> OpenAPI 3.0) #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I noticed that none of the successful responses have a fleshed out schema. Why is that? |
@douglasmanzelmann - can you please create an issue that details 1) what you are currently experiencing and 2) what your expectation of the data is? That way, we can analyze what you report. Thank you. |
1 similar comment
@douglasmanzelmann - can you please create an issue that details 1) what you are currently experiencing and 2) what your expectation of the data is? That way, we can analyze what you report. Thank you. |
Considering this isn't merged, would creating an issue make sense? As for what I'm expecting, here's an example of the issue. A successful response returns an object without specifying any of the fields that would be returned. So if I wanted to generate an API client from this, it would still require a lot of manual work and guess work to know what would come back. |
Thanks - this is helpful. No issue needed here. |
|
@apreiter18 Saw that this is due for release in January with the return fields/types. And noticed this was updated, too: https://gpo.congress.gov/#/. Really appreciate it! |
|
Hi @douglasmanzelmann - just a quick note: please use api.congress.gov, not gpo.congress.gov. This is a legacy URL that we are working to remove from search engines, etc. Thanks! |
@apreiter18 Duly noted! Thank you. One thing about the schema (and there's an issue somewhat relating to this here), is there are a few validation issues. They're all relatively easy to fix, I believe, and I'm open to opening a PR with potential fixes, but if you paste either the json or yaml schema into something like this https://editor.swagger.io/, you'll see the errors. Using a code generator with the schema, I encountered these errors and until they're fixed, it's not able to generate code. Edit: |
Addresses #280