Tidy up HTML: remove unnecessary copies of side menu and use frameset properly#1
Open
fpiesche wants to merge 8 commits intoLibreQuake:mainfrom
Open
Tidy up HTML: remove unnecessary copies of side menu and use frameset properly#1fpiesche wants to merge 8 commits intoLibreQuake:mainfrom
fpiesche wants to merge 8 commits intoLibreQuake:mainfrom
Conversation
fpiesche
commented
Aug 2, 2025
fpiesche
commented
- Add a Github workflow that'll lint HTML and CSS on any PR
- Fix a wide range of HTML issues, from deprecated features (aside from the main frameset) to missing tags and malformed structure
- Break all CSS and JavaScript out into external files so only one copy needs maintaining
- Remove duplicate copies of the menu HTML to make better use of the frameset
- Add menu entries for the credits and copyright info pages
Add menu entries for copyright and credits.
Author
|
I haven't looked at the CSS linter complaints here yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.