Continue PR #7342: mobile signature placement flow by vitormattos · Pull Request #7408 · LibreSign/libresign

vitormattos · 2026-04-04T18:58:47Z

This PR continues the work from #7342 while preserving the original commit history from the abandoned branch.

What was done in this continuation:

Added a follow-up commit to fix TypeScript typing in src/tests/components/PdfEditor/PdfEditor.spec.ts for runtime-only mock members used by mobile placement tests.
Revalidated frontend checks locally for the impacted scope.

Validation run:

npm run ts:check
npm run test -- src/tests/components/PdfEditor/PdfEditor.spec.ts src/tests/components/Request/VisibleElements.spec.ts src/tests/components/RightSidebar/RequestSignatureTab.spec.ts src/tests/store/files.spec.ts

Notes:

Original PR Fix mobile signature placement flow, save visibility, and coordinate serialization #7342 points to a fork branch (Phillipxh:fix/mobile-signature-placement), so it could not be updated directly from this repository.

Signed-off-by: Phillip <phillipxh@gmail.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

- allow self worker-src on authenticated and public sign pages - normalize mailpit sign links to app-relative paths - add regression coverage for sign link extraction and sign-page CSP - configure native signing without TSA in the affected public-sign E2E flows - stabilize unauthenticated sign flows by clearing browser cookies before opening public links Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Phillipxh and others added 5 commits March 30, 2026 22:05

fix(mobile): fix signature placement and coordinate serialization

9dbd66f

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): harden touch placement and pdf-elements runtime behavior

2a18478

Signed-off-by: Phillip <phillipxh@gmail.com>

test(mobile): increase coverage for signature placement flows

64bfae6

Signed-off-by: Phillip <phillipxh@gmail.com>

fix(mobile): restore sign flow fallback for self-signer requests

46b1265

Signed-off-by: Phillip <phillipxh@gmail.com>

test: fix PdfEditor spec runtime mock typing

64c1367

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

github-project-automation bot added this to Roadmap Apr 4, 2026

github-project-automation bot moved this to 0. Needs triage in Roadmap Apr 4, 2026

vitormattos added 18 commits April 4, 2026 16:04

chore(deps): bump pdf-elements to 1.1.4

55fb2c6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements

369182b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): remove touchend workaround internals

c8cfee7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): decouple model from pdf-elements type export

6404102

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-worker): import worker setup from exported asyncReader path

16c2c28

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(pdf-editor): drop workaround-specific touchend specs

5af2630

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(vite): remove pdf-elements runtime patch plugin

f3f06e6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): bump pdf-elements to 1.1.5

d28214d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore(deps): refresh lockfile for pdf-elements 1.1.5

e974e8f

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-editor): use pdf-elements exported object type

ca7e19c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(pdf-worker): restore root setWorkerPath import

cdca3a3

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(sign-route): avoid stale sign_request_uuid fallback

824db70

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test(sign-route): cover stale state UUID regression

cb8c40a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(pdf-editor): use theme tokens for action buttons

6711341

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix(playwright): normalize sign links to relative app paths

c6be91e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

refactor(playwright): simplify sign-link extraction to relative path

006e9fa

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Merge origin/main into pr-7342: resolve mailpit sign-link conflict

66c1b4e

vitormattos force-pushed the fix/mobile-signature-placement branch from 70477b3 to 197aa75 Compare April 4, 2026 22:15

vitormattos added 4 commits April 5, 2026 00:01

fix: alias pdf-elements to source in vite

2325014

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: align pdf-elements alias in vitest

452abc5

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: set pdf worker path synchronously

6523a77

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: initialize pdf worker before editor mount

933d326

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

vitormattos added 25 commits April 5, 2026 00:01

fix: resolve nested visible element pdf urls

8a9491e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: load request signature modal pdf blobs

d8b789e

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: sync right sidebar open state

b4e5e7b

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: mark sign store mounted on selection

b5ed6b1

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: hydrate internal sign view from file detail

3e17526

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: use signer uuid fallbacks in file actions

c0e9a50

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: preserve selection while sign sidebar stays open

b090192

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover pdf editor worker ordering

0dd6133

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover visible elements modal pdf fallbacks

63ff0da

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover right sidebar open sync

e38bc77

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover recursive visible element file urls

90ba680

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover sign store mounted state

4508965

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover internal sign route hydration

ed6d290

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover file entry signing uuid fallbacks

71cedbd

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: cover files list selection cleanup

a9fa188

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: clear signature elements during e2e setup

01e8934

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: wait for sign route before native engine signing

b7caf1d

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: stabilize drawn signature e2e flow

20ddd33

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

fix: warm up pdf-elements worker from package

2861ca6

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: drop pdf-elements vite alias

c5c007a

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: drop pdf-elements vitest alias

6ff3be7

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: mock package worker warmup in visible elements

75cf06c

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

test: mock package worker warmup in request tab

fec5553

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: depend on pdf-elements 1.1.6

0006539

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

chore: refresh frontend lockfile

1699055

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Continue PR #7342: mobile signature placement flow#7408

Continue PR #7342: mobile signature placement flow#7408
vitormattos wants to merge 52 commits intomainfrom
fix/mobile-signature-placement

vitormattos commented Apr 4, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vitormattos commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vitormattos commented Apr 4, 2026 •

edited

Loading