[13기] 서병주 과제 제출합니다. #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7SH7
reviewed
Jan 23, 2025
7SH7
left a comment
7SH7
left a comment
There was a problem hiding this comment.
- 풀더명은 소문자로 해주세요.
- dto에 request, response를 다 넣어도 되지만, request와 response는 controller에서 사용하기 때문에, controller에 넣어서 관리하길 추천드립니다. (병주님이 편하다면, 기존대로 dto에 넣으셔도 무방합니다.)
- Response, Request를 만들어서 처리하는 것에 일관성을 두시고 코딩하기를 추천드립니다.
| .build(); | ||
| } | ||
|
|
||
| public void returnLoan() { |
There was a problem hiding this comment.
이런 식으로 domain의 값들을 변경하게 하는 것들은 domain에서 선언해서 처리해주는 것이 좋습니다.
(domain의 값 변화 관련 함수는 domain 해당 파일에 선언해주는 것이 좋음.)
|
|
||
|
|
||
| @PostMapping("/books/{bookId}/checkout") | ||
| public ResponseEntity<String> checkoutBook(@PathVariable long bookId, @RequestBody LoanRequest loanRequest) { |
There was a problem hiding this comment.
반환 type은 String 이렇게 말고 Response 형태로 만들어서 보내주세요! (통일성을 위해서)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.