Masternode UI tab updates and a performance improvement.#56
Open
Tumba24 wants to merge 8 commits intoLindacoin:masterfrom
Open
Masternode UI tab updates and a performance improvement.#56Tumba24 wants to merge 8 commits intoLindacoin:masterfrom
Tumba24 wants to merge 8 commits intoLindacoin:masterfrom
Conversation
added 8 commits
May 2, 2018 09:51
This makes it so your selection doesn't move when new rows are added.
Additional masternodes will have (suffixNum) appended to addr.
|
@Tumba24, Sorry for the offtopic, can you give a link to the manual to run 2 masternides on one ip? |
Author
|
@MoNTE48 As far as I know you can't properly host two masternode pinging services from one wallet at the moment. This is true of most masternode coins. Some users are using custom applications and scripts to work around the issue with varying levels of success. Currently the best way I know of to run multiple masternodes from one ip is to use multiple wallets and ports assuming your computer is powerful enough. I don't know of an existing detailed guide for this setup sorry. |
|
Awesome work Tumba. |
|
This helped a lot with freezing wallet on Windows 10, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a. Problem: The masternodes UI tab uses a lot of resources when it refreshes.
b. Solution: Made updates to masternode.cpp that allow for the calculation of masternode scores to be done outside of GetMasternodeRank so that these scores can be passed to GetMasternodeRank for the purpose of making multiple calls to GetMasternodeRank more efficient. Implemented these changes in massternodemanager.cpp. These changes could also be beneficial to other areas that I haven't updated.
a. Problem: The masternodes UI tab doesn't allow for any sorting.
b. Solution: Disable sorting at the start of the row update processes and re enable it at the end. I also updated some of the columns to have numeric values instead of strings so that sorting would work better.
a. Problem: When multiple masternodes are running under the same ip and port, only one shows up on the masternode tab.
b. Solution: Additional masternodes will now show up with a suffix number appended to the masternode's address in the format: ip:port (number). An alternative solution would be to show part of the masternode's vin but I thought this approach would be less controversial.