Fix to multiprocessing of Lomb-Scargle significant testing for Mac OS and scipy version greater than 1.15 #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a problem with multiprocessing on a Mac. Ticks version of Python. Tested locally on 3.11 and 3.12
CommonClimate
approved these changes
Oct 16, 2025
Collaborator
CommonClimate
left a comment
CommonClimate
left a comment
There was a problem hiding this comment.
Thanks for doing it. I'm wondering the best way to make a note of this for when SciPy/Numpy resolve the issue on a mac. Also, we should make sure it's explained in the release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pushes a "fix" to be able to compute the surrogates and perform spectral analysis in parallel. not exactly a fix: if on Mac, the default behavior is to execute in series for this method. Everything else remains in parallel.
Also added a test for Lomb-Scargle specifically in
core_test_PSD.py.Ticked version of Python to 3.12