-
Notifications
You must be signed in to change notification settings - Fork 8
Static site generator rewrite #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
create redirects
fix redirects for GH pages
error pages
fix redirects for GH pages
tedm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rewrite seems fine.
|
I ran Lighthouse, biggest issues were asset cache header time (nothing can be done about that when served from GitHub pages), and oversized images on mobile (#19) |
.github/workflows/static.yml
Outdated
|
|
||
| - name: Build project | ||
| env: | ||
| BASE_PATH: /Local-Connectivity-Lab.github.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.


Complete rewrite using Sveltekit.
/aboutUs.html->/about-us, sadly GH pages doesn't provide a mechanism for redirects, I had to add them client side, eg /aboutUs.html.fixes #12
fixes #15