Skip to content

Fixes regarding external assembly references which cannot be resolved #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjgertsen wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes regarding external assembly references which cannot be resolved #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e5f9aa
type.assembly will never be the same as sourceassembly in case source…
mjgertsen Apr 15, 2024
7baca12
Value provided for type parameters on customattributes which are not …
mjgertsen Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/AssemblyGenerator.Attributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ static void EncodeLiteral(LiteralEncoder litEnc, CustomAttributeTypedArgument ar
if (arg.Value is Type type)
{
// Type reference
litEnc.Scalar().SystemType(type.FullName);
litEnc.Scalar().SystemType(type.AssemblyQualifiedName);
}
else if (arg.Value is ReadOnlyCollection<CustomAttributeTypedArgument> array)
{
Expand Down Expand Up @@ -162,4 +162,4 @@ static PrimitiveSerializationTypeCode PrimitiveTypeCodeFromSystemTypeCode(Type t
throw new NotImplementedException($"Unsupported primitive type: {type}");
}
}
}
}
4 changes: 2 additions & 2 deletions src/Metadata/AssemblyMetadata.Types.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public bool IsReferencedType(Type type)

// todo, also maybe in Module, ModuleRef, AssemblyRef and TypeRef
// ECMA-335 page 273-274
return type.Assembly != SourceAssembly;
return !SourceAssembly.FullName.Equals(type.Assembly.FullName);
}

private EntityHandle ResolveTypeReference(Type type)
Expand Down Expand Up @@ -141,4 +141,4 @@ private StringHandle GetNamespaceForType(Type type)
return type.IsNested ? default : GetOrAddString(type.Namespace);
}
}
}
}