fix: Match accuracy for pathing, walktriggers, and collision#78
Merged
Pazaz merged 19 commits intoLostCityRS:274from Mar 17, 2026
Merged
fix: Match accuracy for pathing, walktriggers, and collision#78Pazaz merged 19 commits intoLostCityRS:274from
Pazaz merged 19 commits intoLostCityRS:274from
Conversation
added 2 commits
February 17, 2026 19:48
added 10 commits
February 19, 2026 15:43
Contributor
Author
|
Made some further changes to match edge cases. I think I have every case matched!! The pathing rules are as follows:
ClipsRestless Ghostghost.clip.OG.mp4Replay.2026-02-22.16-24-40.mp4Hassanhassan.test.OG.mp4hassan.test.mp4Sheepsheep.clip.good.mp4Replay.2026-02-22.16-50-44.mp4 |
Contributor
Author
|
Rebased this PR to target 274, fixed the last few pathing edge cases, and fixed collision drezel.impl.mp4Can compare this new behavior to these clips: Replay.2026-03-15.18-40-28.mp4This is new as well. Previously the cat would not get stuck on the guard here. Players and Npcs now refresh their zone presence when they have a waypoint, even if they are not actively moving, so the cat gets stuck These changes should affect all branches, if that's feasible. This PR is now ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current engine implementation for pathing and walktriggers is some bastard hybrid between authentic 2004-2007 pathing and the OSRS pathing updates in dec 2013, due to a lack of information when it was coded
After reviewing lots of footage, the following changes have been made:
Clips
Moonwalk
2004-2007 example:
authentic.moonwalk.mp4
Before this PR:
Replay.2026-02-17.20-21-45.mp4
After this PR:
2004.new.moonwalk.mp4
Getting stuck in pvp
2004-2007 example:
authentic.getting.stuck.mp4
Before this PR:
Replay.2026-02-17.20-41-35.mp4
After this PR:
Replay.2026-02-17.20-42-46.mp4
Clips referenced
https://youtu.be/rdi_571Uk_U?t=292
https://youtu.be/RZfT_W9ANl0?t=1156
https://youtu.be/nTjk2vweCD0
https://youtu.be/zKNeTSsuf0E?t=168
https://youtu.be/JJ5wulUYXxA?t=153
https://youtu.be/_MVBI81kQDM?t=5
https://www.youtube.com/watch?v=dKfFkEyqD8E&t=9s
https://www.youtube.com/watch?v=TnBJZD9AcJE