Skip to content

hotfix: include experimental patches (temporary workaround, pending upstream...)#179

Draft
Zebra2711 wants to merge 10 commits intoLotusInputMethod:devfrom
Zebra2711:next
Draft

hotfix: include experimental patches (temporary workaround, pending upstream...)#179
Zebra2711 wants to merge 10 commits intoLotusInputMethod:devfrom
Zebra2711:next

Conversation

@Zebra2711
Copy link
Copy Markdown
Contributor

@Zebra2711 Zebra2711 commented Mar 28, 2026 •
edited
Loading

@Miho1254 mode chỉ dành cho libreofice :)

Patch list:

  • Fix chromium wayland suggestion đã fix trong 77891e8 nhưng lại bị lại sau rofi fix db3ec0a
  • Dùng deleteSurroundingText trong libreofice
  • Retry cho app trong list need ack only

@github-project-automation github-project-automation bot moved this to Backlog in Kanban Mar 28, 2026
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LotusState::performReplacement function to utilize deleteSurroundingText for applications that support it, aiming for a smoother typing experience. The review feedback identifies a critical issue where calling .back() on an empty string could cause a crash and points out a block of dead code resulting from contradictory logic regarding the autofillOffset variable.

@Miho1254
Copy link
Copy Markdown
Contributor

Miho1254 commented Mar 28, 2026

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

@Zebra2711
Copy link
Copy Markdown
Contributor Author

Zebra2711 commented Mar 28, 2026

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

mấy thằng khác dùng đc nhưng bị lỗi :v

@Zebra2711 Zebra2711 marked this pull request as draft March 28, 2026 14:24
@nhktmdzhg
Copy link
Copy Markdown
Collaborator

nhktmdzhg commented Mar 28, 2026

@Miho1254 mode chỉ dành cho libreofice :)

có mỗi thằng libre support API này thôi à

thằng nào gtk với qt là được, thậm chí firefox cũng có, lỏ quá thôi

@Zebra2711 Zebra2711 force-pushed the next branch 5 times, most recently from 41ef9d1 to 08341ee Compare March 28, 2026 15:57
@Zebra2711 Zebra2711 changed the title feat: use deleteSurroundingText for app support hotfix: include experimental patches (temporary workaround, pending upstream...) Mar 28, 2026
@Zebra2711 Zebra2711 force-pushed the next branch 5 times, most recently from 218dcce to 5c53cdb Compare March 30, 2026 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@shadichy shadichy shadichy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zebra2711 @Miho1254 @nhktmdzhg @shadichy