Update Add button state in Keymap Editor#191
Merged
nhktmdzhg merged 5 commits intoLotusInputMethod:devfrom Mar 30, 2026
Merged
Conversation
…98958473316767 🎨 Palette: Update Add button state in Keymap Editor
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the keymap editor UI by dynamically updating the 'Add' button to an 'Update' button when an existing key is entered and disabling it when the input field is empty. Review feedback suggests optimizing the implementation by removing redundant signal connections and function calls, and refactoring the key-searching logic into a dedicated helper method to improve maintainability and reduce code duplication.
…te calls in editors
…o ensure consistent state updates
Collaborator
|
Anh ấy đã trở lại 🐧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Làm cho hành vi của nút Add/Update của bên keymap giống như bên macro, nếu trùng lặp thì thay Add -> Update, nếu rỗng thì ngăn không cho Add.