Conversation
Updated curling physics to use a 20-point integration model that decouples Total Friction from Curl Asymmetry. Introduced new tuning constants: - curl_decay: Controls curl drop-off at high speeds - pivot_bias: Front-to-back friction difference - lateral_mult: Multiplier for rotational influence Updated DEFAULT_PHYSICS constants and ensured state initialization merges with localStorage to support returning users. Verified via Playwright. Co-authored-by: LrWm3 <9008889+LrWm3@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying lrwm3g with
|
| Latest commit: |
68ecc33
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cbfeefe3.lrwm3g.pages.dev |
| Branch Preview URL: | https://curling-physics-update-18093.lrwm3g.pages.dev |
…lity fixes
Updated curling physics to use a 20-point integration model that decouples
Total Friction from Curl Asymmetry.
Key changes:
- Introduced new tuning constants: `curl_decay`, `pivot_bias`, and `lateral_mult`.
- Updated existing physics constants to new calibrated defaults.
- Rewrote `Stone.step(dt)` to use the new physics model.
- Added stability fixes to the physics model:
- Ensured friction coefficient `mu` is non-negative.
- Implemented a friction clamp to prevent velocity overshoot at large time steps.
- Updated React state initialization to merge defaults with localStorage.
Verified that stones stop correctly within a few seconds after delivery.
Co-authored-by: LrWm3 <9008889+LrWm3@users.noreply.github.com>
…s and spin decay - Implemented the 20-point friction integration model. - Added tuning constants: curl_decay, pivot_bias, lateral_mult. - Fixed the stopping issue with a friction clamp. - Fixed curl direction: Clockwise spin now correctly curls Right. - Fixed spin decay: Friction now correctly opposes rotation. - Updated React state to handle localStorage migration. - Verified with Playwright screenshots. Co-authored-by: LrWm3 <9008889+LrWm3@users.noreply.github.com>
Implemented a new, more realistic physics model for the curling game.
The update includes:
DEFAULT_PHYSICS:curl_decay,pivot_bias, andlateral_mult.mu_0,A,spin_rate,restitution, andstone_friction.Stone.step(dt)method using a 20-point integration model.localStorage.server.logfile before submission.PR created automatically by Jules for task 18093505600013104836 started by @LrWm3