Refactor update_kernel_sp function#112
Merged
LuernOutOfOrder merged 1 commit intodevelopfrom Feb 3, 2026
Merged
Conversation
…ic API from kernel mem module to update the kernel sp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the kernel stack pointer is updated in the RISC-V32 architecture. The main change is to make the stack pointer update function accept an explicit stack pointer argument, improving clarity and modularity. The update also reorganizes related code into more appropriate modules.
Refactoring and modularization of kernel stack pointer update:
update_kernel_sp(sp: usize)function tosrc/arch/riscv32/mem.rs, which sets the kernel stack pointer using an explicit argument.update_kernel_sp()function insrc/mem/mod.rswith a newmem_update_kernel_sp()function, which retrieves the stack pointer from memory and calls the newupdate_kernel_sp(sp)function.src/boot.rsto usemem_update_kernel_sp()instead of the previousupdate_kernel_sp(). [1] [2]arch::riscv32::memmodule and updated imports accordingly. [1] [2]This pull-request improve the codebase by avoiding that the kernel function use arch specific asm, leave the asm in the arch specific module.