Merged
Conversation
…d-to-run-in-config 120 add a list of command to run in config
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…o-nyx-usage-message Add missing usage for update command
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…fig-option-enabled 136 add log files if config option enabled
105 fix all clippy warnings
Fix panic on pbcopy
Add config.toml file
…ve unused clone() to prefer borrow checker
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…hub.com:LuernOutOfOrder/NYX into 140-check-all-codebase-to-optimize-memory-usage
…o-optimize-memory-usage Optimize memory usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the
nyxCLI tool, focusing on code quality enhancements, usability improvements, and new functionality. The most significant changes include the addition of command aliases in the Cargo configuration, the introduction of a newhealthmodule, and the removal of redundant helper functions for logging. Additionally, multiple refactorings were performed to improve code readability and efficiency.Usability Improvements:
.cargo/config.toml: Added command aliases for commoncargooperations such as build, test, run, and clippy, making commands shorter and easier to use. Also added afuture-incompat-reportconfiguration to display warnings about future incompatibilities.Cargo.toml: Updated the version of thenyxpackage from2.8.0to2.10.2.New Functionality:
src/health/mod.rs: Introduced a newhealthmodule to check user environment health based on configuration files, with support for system and network health checks.Code Simplification and Refactoring:
src/cleanup/mod.rs,src/git/mod.rs,src/hello/mod.rs,src/doctor/mod.rs: Refactored multiple functions to use&strinstead ofStringwhere possible, replacedString::from_utf8_lossywithstr::from_utf8for more efficient string handling, and removed unnecessary.to_string()calls. [1] [2] [3]src/doctor/helper.rs: Removed redundant helper functions (installed,not_installed,warning) and replaced their usage with centralized logging functions. [1] [2]Code Quality Improvements:
.github/workflows/rust.yml: Added a linting step usingcargo clippyto enforce coding standards and prevent warnings.src/cleanup/mod.rs: Improved error messages and logging by replacing.to_string()with.to_owned()for better performance and clarity. [1] [2]These changes collectively enhance the usability, maintainability, and functionality of the
nyxCLI tool.